set LC_ALL=C when running Perl test suite#425
Conversation
|
@wpoely86: please review? |
There was a problem hiding this comment.
why not show the output by default? We do that with the other make commands?
There was a problem hiding this comment.
the output is shown, but I moved the self.log.debug line up now to make that more clear
There was a problem hiding this comment.
No, what I mean is: we run all other make commands with log_all=True so that you get the output if you run with -l. Why only show the make test output when running in debug mode?
There was a problem hiding this comment.
the log_all needs to be False in order to capture the exit code ourselves
I'll try setting the locale hard though, rather than allowing individual tests to fail.
|
Can we not force the local to "C"? |
|
@wpoely86: I don't think it's a good idea to force a particular locale when running the Perl tests, since that's kind of cheating. |
|
@boegel it is cheating but if it fails because of a local, it's a bug. Now we don't even know if it works with local C (and is a local problem) or is it a real bug? |
|
Remark by @wpoely86 fixed, tested with easybuilders/easybuild-easyconfigs#977, so going in. Thanks @wpoely86 for the critical review! |
allow minimal amount of failing tests for Perl
LC_ALL=C when running Perl test suite
A handful of individual tests sometimes fail for Perl, usually because of locale settings.
The PR allows that less than 1% of the tests fail, and also makes sure
make testis always run (except whenruntestis explicitly set toFalse.