Skip to content

Use *buildopts instead of *makeopts in configuremake & pythonpackage#427

Merged
boegel merged 4 commits intoeasybuilders:developfrom
wpoely86:nomakeopts
Jul 7, 2014
Merged

Use *buildopts instead of *makeopts in configuremake & pythonpackage#427
boegel merged 4 commits intoeasybuilders:developfrom
wpoely86:nomakeopts

Conversation

@wpoely86
Copy link
Copy Markdown
Member

Get rid of the deprecated warnings.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 20, 2014

@wpoely86: why limit yourself to only these two easyblocks? ;-)

Replacements like this should be safe since EasyBuild v1.13, this will still work even if the easyconfig only defines makeopts, so let's just replace makeopts and premakeopts in all existing easyblocks?

@wpoely86
Copy link
Copy Markdown
Member Author

@boegel at your request, this is the result of s:\<premakeopts\>:prebuildopts:g and s:\<makeopts\>:buildopts:g

Comment thread easybuild/easyblocks/i/imkl.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the extramakeopts too?

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 21, 2014

@wpoely86: nice, thanks. One tiny remark.

Are you up for also doing this in the easyconfigs repo? That we, we should be able to rebuild all of the ones being touched there using this easyblocks branch and upload a test report in the easyconfigs PR, just to make sure we're not breaking anything (should be fine, but we better make sure).

@wpoely86
Copy link
Copy Markdown
Member Author

@boegel Sure, no problem. But should we wait with that PR until the merge windows closes? Then we're sure to have everything?

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 21, 2014

@wpoely86: I plan to make the easyconfig unit tests capture any use of makeopts/premakeopts, and crash on it. So we will notice.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 7, 2014

@wpoely86: merge with develop is broken, please fix (I want to get this in for EasyBuild v1.14, postponing this further will be a pain)

@wpoely86
Copy link
Copy Markdown
Member Author

wpoely86 commented Jul 7, 2014

@boegel please merge #423 then first.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 7, 2014

@wpoely86 #423 is merged

* develop:
  fix remark
  icc: change point when to drop idb
  fix remarks
  include --ignorearch when installing rebuilt RPMs
  don't try to enforce x86_64 build arch when rebuilding rpms
  fix poor mans version of toolchain compiler detection in imkl easyblock
  icc: idb is deprecated
  fix typo
  enhance BLAT easyblock by using super's build_step and prebuildopts/buildopts
  add easyblock for HPCG

Conflicts:
	easybuild/easyblocks/b/blat.py
	easybuild/easyblocks/i/imkl.py
@wpoely86
Copy link
Copy Markdown
Member Author

wpoely86 commented Jul 7, 2014

@boegel ready for merge

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 7, 2014

@wpoely86: reviewed (again), and ran a few tests, looking great, so going in. thanks!

boegel added a commit that referenced this pull request Jul 7, 2014
Use *buildopts instead of *makeopts in configuremake & pythonpackage
@boegel boegel merged commit a360ecf into easybuilders:develop Jul 7, 2014
@wpoely86 wpoely86 deleted the nomakeopts branch July 8, 2014 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants