Petsc conifg opts changed#446
Conversation
…sybuild-easyblocks into petsc_conifg_opts_changed
|
Automatic reply from Jenkins: Can I test this? |
There was a problem hiding this comment.
Extend this to cmd = "%s make %s" % (self.cfg['prebuildopts'], self.cfg['buildopts'])
Can you not simpily set self.cfg['parallel'] to None and use the configuremake build_step?
|
ok to test |
if suitesparse if loops corrected
def build_step removed, and -j issue for make solved using self.cfg['paeallel'] to None.
There was a problem hiding this comment.
this needs to be a indenting level deeper (in the function)
There was a problem hiding this comment.
But then it should be earlier in the file, right?
There was a problem hiding this comment.
the location is fine (in the configure_step() ) but the code is on the same level as the methods. It needs to happen in a method 😉
There was a problem hiding this comment.
I think it's best to also set LIBS and LD_FLAGS in configopts?
(btw, is the -- needed?)
|
I am not sure whether we need -- or not. According to configure --help we need, but based on some of the messages written by configure is not needed. I would stick to the version suggested by configure --help. I am also not completely sure about setting the LIBS and LD_FLAGS options as well, because this is not a standard configure script, actually it is a python script and it is quite picky how different options are set. If we set LIBS and LD_FLAGS then they needed to set probably for the previous versions as well. Anyway, from the config log I can see the following: https://gist.github.com/hajgato/3b13d060d869f225868f So, it looks that the libs and LD_FLAGS are correctly set. |
|
alright, correct, seems to work here, |
|
@JensTimmerman Well, the options are there in the configure part. I think if it does not recognize FIAT and scientificpython , their lines would not be there. Anyway, here is the full buildlog: |
|
From software/PETSc/3.5.1-intel-2014b-Python-2.7.8/conf/configure.log |
|
Apparently FIAT and scientificpython in the PYTHONPATH |
|
Yeah, I might have read the config output wrong, it is listed, but has nothing behind it, which was looking weird to me, |
There was a problem hiding this comment.
@hajgato: correct me if I'm wrong, but this is just an unrolled version of the loop in the else part, but with BLACS excluded?
If so, we should rework this to:
deps = ["FFTW", "ScaLAPACK"]
if LooseVersion(self.version) < LooseVersion("3.5"):
deps.append("BLACS")
# loop in else part over 'deps'
No description provided.