add support for specifying an activation key after installing Mathematica#452
Merged
boegel merged 5 commits intoeasybuilders:developfrom Aug 15, 2014
Merged
Conversation
Member
Author
|
@wpoely86: please review? |
Member
There was a problem hiding this comment.
any reason why these are 'raw' while the noqa string aren't?
Member
Author
There was a problem hiding this comment.
not really in this case I think, but it's good practice to use raw strings for stuff that will be consumes by re.compile, I'll change it in the noqa part too
Member
Author
There was a problem hiding this comment.
actually, the noqa strings should not be raw strings, otherwise \s would be escaped...
Member
|
Looking good |
Member
Author
|
going in, thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Aug 15, 2014
add support for specifying an activation key after installing Mathematica
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.