Skip to content

only include major/minor version numbers for FLUENT subdir#480

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:fluent_verdir
Oct 2, 2014
Merged

only include major/minor version numbers for FLUENT subdir#480
boegel merged 2 commits intoeasybuilders:developfrom
boegel:fluent_verdir

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 1, 2014

This fixes installing FLUENT v15.0.7, where the subdirectory is v150 rather than v1507.

@wpoely86: please review?

Comment thread easybuild/easyblocks/f/fluent.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate code of L60, do it once and store it?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 1, 2014

@wpoely86: remark fixed

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Oct 1, 2014

looks great then :)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 2, 2014

Merging in, thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Oct 2, 2014
only include major/minor version numbers for FLUENT subdir
@boegel boegel merged commit a6e32b2 into easybuilders:develop Oct 2, 2014
@boegel boegel deleted the fluent_verdir branch October 2, 2014 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants