METIS easyblock taking into account configopts#494
METIS easyblock taking into account configopts#494boegel merged 9 commits intoeasybuilders:developfrom
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
Jenkins: ok to test |
|
Test PASSed. |
|
Jenkins: test this please |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
minor style issue: space after ,
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/988/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel metis easyblock corrected |
There was a problem hiding this comment.
this is a very involved bit of code, why not simply enable building of the .so by always including shared=1?
# in configure_step
self.cfg.update('configopts', 'shared=1')Alternatively, if you check for shared=1 in self.cfg['configopts'] in configure_step, you don't need to worry about checking whether self.cfg['configopts'] is a list or not (you can assume it'll be a string when in configure_step, in fact, we already do when constructing cmd).
There was a problem hiding this comment.
METIS makes shared object or archive. Never both. If I use the above mentioned line, I might break old builds, if they would not work with the shared object file.
I had to give a list in my METIS easyconfig to build both archive and shared object.
configopts = [' ', 'shared=1 ']
There was a problem hiding this comment.
OK, thanks for clarifying that.
But, we should still move the check which libraries should get installed to configure_step, to avoid dealing with the list/string status of configopts.
I'll send a PR your way for that.
move libext check to configure_step
sync with develop
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
fix double '.' in lib exts
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Works fine, all existing METIS easyconfigs still work with this in place, see https://gist.github.com/6373a7707218240528a3. The METIS easyconfig included in easybuilders/easybuild-easyconfigs#1166, for which both Thanks @hajgato! |
METIS easyblock taking into account configopts
No description provided.