add type check in CP2K easyblock#509
Merged
boegel merged 2 commits intoeasybuilders:developfrom Nov 14, 2014
Merged
Conversation
|
Test PASSed. |
Member
There was a problem hiding this comment.
why not:
if self.cfg['type'] not in known_types:
Member
Author
There was a problem hiding this comment.
you're right, that's better, will fix, thx
|
Test PASSed. |
Member
Author
|
Going in, thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Nov 14, 2014
add type check in CP2K easyblock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wpoely86: please review