Merged
Conversation
|
Test PASSed. |
Member
There was a problem hiding this comment.
docstring please; suggestion:
"""Custom extraction of sources for Chimera: unpack installation file to obtain chimera.bin installer."""|
Test PASSed. |
Member
There was a problem hiding this comment.
please import from tools.run instead, once #523 is merged in, this will trip a failing unit test...
see also http://boegel-eb.readthedocs.org/en/deprecated/Deprecated-functionality.html#renamed-relocated-functions (pending documentation update, cfr. easybuilders/easybuild#54)
|
Test PASSed. |
Member
There was a problem hiding this comment.
another tiny remark... it's better to do the cd part in Python code:
try:
os.chdir(self.cfg['start_dir'])
except OSError, err:
self.log.error("Failed to change to %s: %s" % (self.cfg['start_dir'], err))
cmd = "./chimera.bin -q -d %s" % self.installdir
run_cmd(cmd, log_all=True, simple=True)|
Test PASSed. |
|
Test PASSed. |
Member
|
Looking great now, going in, easybuilders/easybuild-easyconfigs#1255 will follow Thanks @pescobar! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.