Skip to content

relocate FDTD RPM to fix installation on SL6#538

Merged
boegel merged 4 commits intoeasybuilders:developfrom
boegel:FDTD_relocate_rpm
Jan 16, 2015
Merged

relocate FDTD RPM to fix installation on SL6#538
boegel merged 4 commits intoeasybuilders:developfrom
boegel:FDTD_relocate_rpm

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 16, 2015

@boegel boegel mentioned this pull request Jan 16, 2015
Merged
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jan 16, 2015

Test PASSed.

wpoely86
wpoely86 reviewed Jan 16, 2015
View reviewed changes
Comment thread easybuild/easyblocks/f/fdtd_solutions.py
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Jan 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason why you need glob here? There is a 'random' part in the filename?

Copy link
Copy Markdown
Member Author

@boegel boegel Jan 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just don't want to make any assumptions here. In the versions I've tested have 'el5' in them, but I don't think that's a safe assumption to make for future versions.

@JensTimmerman
Copy link
Copy Markdown

JensTimmerman commented Jan 16, 2015

ok

wpoely86
wpoely86 reviewed Jan 16, 2015
View reviewed changes
Comment thread easybuild/easyblocks/f/fdtd_solutions.py
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Jan 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why renamed? We're not going to use the original one anymore?

Copy link
Copy Markdown
Member Author

@boegel boegel Jan 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly for debugging purposes, this will be cleaned up once the installation succeeds anyway

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jan 16, 2015

Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 16, 2015

fixes the FDTD build, see easybuilders/easybuild-easyconfigs#1307

also verified that this doesn't break the installation of QLogicMPI, which relies on the Rpm easyblock

so, going in, thanks for the thorough review @wpoely86!

boegel added a commit that referenced this pull request Jan 16, 2015
@boegel
Merge pull request #538 from boegel/FDTD_relocate_rpm
5986380 
relocate FDTD RPM to fix installation on SL6
@boegel boegel merged commit 5986380 into easybuilders:develop Jan 16, 2015
@boegel boegel deleted the FDTD_relocate_rpm branch January 16, 2015 16:38
@boegel boegel mentioned this pull request Jan 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @hpcugentbot @JensTimmerman @wpoely86