In the generic CMake class: always be verbose#546
Merged
boegel merged 1 commit intoeasybuilders:developfrom Feb 4, 2015
Merged
In the generic CMake class: always be verbose#546boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
|
Test PASSed. |
Member
There was a problem hiding this comment.
maybe only set this if debug logging is enabled?
Member
Author
There was a problem hiding this comment.
Why? The logging options already decide over what run_cmd should display. And I cannot think of a single reason why we wouldn't want the full output?
Member
There was a problem hiding this comment.
well, bigger logs ;)
but you're right, I see no reason not to include this
others have been doing this for ages, cfr. https://bugzilla.redhat.com/show_bug.cgi?id=474053
Member
|
going in, thanks @wpoely86! |
boegel
added a commit
that referenced
this pull request
Feb 4, 2015
In the generic CMake class: always be verbose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.