Skip to content

add easyblock for Hadoop that supports building native libs#563

Merged
boegel merged 5 commits intoeasybuilders:developfrom
boegel:Hadoop
Feb 23, 2015
Merged

add easyblock for Hadoop that supports building native libs#563
boegel merged 5 commits intoeasybuilders:developfrom
boegel:Hadoop

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 23, 2015

@ehiggs: please review?

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/787/
Test PASSed.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/788/
Test PASSed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this do actually the same as the install_step() from Tarball?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, Tarball copies from a different location

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I guess I could support specifying the location to copy from in Tarball.install_step

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good idea?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/789/
Test PASSed.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/790/
Test PASSed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not an easyblock option?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that makes a lot of sense? usually, no 'source' is involved, and it's just a command to run

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant an easyconfig parameter but it's fine as it is for me.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/791/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 23, 2015

OK, going in, thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Feb 23, 2015
add easyblock for Hadoop that supports building native libs
@boegel boegel merged commit eec91a3 into easybuilders:develop Feb 23, 2015
@boegel boegel deleted the Hadoop branch February 23, 2015 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants