Skip to content

Develop nemo#564

Merged
boegel merged 10 commits intoeasybuilders:developfrom
omula:develop-nemo
Jul 7, 2015
Merged

Develop nemo#564
boegel merged 10 commits intoeasybuilders:developfrom
omula:develop-nemo

Conversation

@omula
Copy link
Copy Markdown
Contributor

@omula omula commented Mar 2, 2015

New EasyBlock to compile NEMO ocean model

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 2, 2015

Jenkins: ok to test

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/796/
Test PASSed.

Comment thread easybuild/easyblocks/n/nemo.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 2015 (new easyblock)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean:

# Copyright 2015-2015 Ghent University

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 26, 2015

@omula: a couple of fairly minor remarks, looks pretty good overall, nice work!

We do need an easyconfig for NEMO too though (via https://github.com/hpcugent/easybuild-easyconfigs/compare), so we can test this...

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/974/
Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/974/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/975/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/975/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 3, 2015

@omula: Works like a charm on my after manually testing using an easyconfig derived from the one in easybuilders/easybuild-easyconfigs#1640.

I tackled a bunch of style aspects for this easyblock, see omula#1 . Please review/merge.

style fixes in NEMO easyblock
@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1049/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1049/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants