Skip to content

fix easyblock for EasyBuild to support upgrade path to EasyBuild v2.0#573

Merged
boegel merged 3 commits intoeasybuilders:masterfrom
boegel:fix_eb20_update_path
Mar 6, 2015
Merged

fix easyblock for EasyBuild to support upgrade path to EasyBuild v2.0#573
boegel merged 3 commits intoeasybuilders:masterfrom
boegel:fix_eb20_update_path

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 6, 2015

The easyblock used for installing EasyBuild included in EasyBuild v1.16.1 is unaware of the extra vsc-base component in the upcoming EasyBuild v2.0.0. This PR fixes that issue, supporting an intermediate release EasyBuild v1.16.2 which does support upgrading to EasyBuild v2.0.0.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/831/
Test FAILed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 6, 2015

Jenkins: test this please

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/832/
Test FAILed.

@rjeschmi
Copy link
Copy Markdown
Contributor

rjeschmi commented Mar 6, 2015

looks fine, I'll keep looking at it though..

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 6, 2015

Jenkins: test this please

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/833/
Test PASSed.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/834/
Test FAILed.

boegel added a commit that referenced this pull request Mar 6, 2015
fix easyblock for EasyBuild to support upgrade path to EasyBuild v2.0
@boegel boegel merged commit 9b1638d into easybuilders:master Mar 6, 2015
@boegel boegel deleted the fix_eb20_update_path branch March 6, 2015 20:08
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this one? If there is only 1 element and it's not vsc-base, we give an error and if it's vsc-base we do nothing?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we basically don't care if vsc-base is not found. If it's needed (EB v2.x), it will be picked up when installing framework.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is handled better in the current version of the EasyBuildMeta easyblock.

This patch is just to release EB v1.16.2, which is required to install EasyBuild v2.0.0 'offline' using EasyBuild (EB v1.16.1 doesn't work).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a comment about that?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this version of the EasyBuildMeta easyblock is dead. The currently active version in develop is the one last tweaked in #567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants