Skip to content

add easyblock for building and installing TINKER#578

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:tinker
Mar 12, 2015
Merged

add easyblock for building and installing TINKER#578
boegel merged 1 commit intoeasybuilders:developfrom
boegel:tinker

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 12, 2015

No description provided.

@JensTimmerman
Copy link
Copy Markdown

looks ok to me

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 12, 2015

broken test reported via https://github.com/jayponder/tinker/issues/7

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's unclear to me, but if this a makefile you're patching, you need $(EBROOTFFTW)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a Makefile, it's a script, basically

see https://github.com/jayponder/tinker/blob/master/linux/intel/link.make

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 12, 2015

Thanks for the review @JensTimmerman & @wpoely86!

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/840/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 12, 2015

Going in, thanks again for reviewing!

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 12, 2015

I was putting this on hold until I had a working test report, which is now there, see easybuilders/easybuild-easyconfigs#1465 (comment).

boegel added a commit that referenced this pull request Mar 12, 2015
add easyblock for building and installing TINKER
@boegel boegel merged commit 7c7d304 into easybuilders:develop Mar 12, 2015
@boegel boegel deleted the tinker branch March 12, 2015 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants