Allow support for MPICH/MPICH2#579
Conversation
|
Automatic reply from Jenkins: Can I test this? |
There was a problem hiding this comment.
looks trivial, but.. .:-)
We should probably be using the mpi_family() function here, rather than relying on get_software_root.
@ocaisa: up for looking into that?
Also: do you have a matching easyconfig to test this change? It's pretty clear that this shouldn't break anything that works already.
|
Jenkins: ok to test |
|
Refer to this link for build results (access rights to CI server needed): |
Along the lines of the imkl easyblock, added support for checking the MPI compatibility based on the toolchain mpi_family() as well as keeping the fallback for weird situations
|
Refer to this link for build results (access rights to CI server needed): |
|
Annoyingly I don't have a verified matching easyconfig, I can't get it build at all on JuropaTest because during the regtest it tries to use mpirun (which is not supported, only srun) so it just hangs. I tried getting it to skip tests but it refuses to |
There was a problem hiding this comment.
hmm, does it make sense to have that in here?
|
@ocaisa: just including 'runtest = False' in the CP2K easyconfig should take care of skipping the |
|
Ah, no, the CP2K easyblock includes this: # always enable testing for CP2K
self.cfg['runtest'] = TrueThat's just wrong... The def extra_options():
...
'runtest': [True, "Build and run WRF tests", CUSTOM],
...Feel free to tackle that too in here, we shouldn't be hard enabling the tests like that. |
|
Refer to this link for build results (access rights to CI server needed): |
The tests currently require mpirun so won't work on systems where that's not available, should give people the opportunity to bypass
|
Refer to this link for build results (access rights to CI server needed): |
|
I'll give it a whirl now and see how it goes |
There was a problem hiding this comment.
since the value for mpi_spec is the same regardless of which toolchain it is, this can be cleaned up a bit to:
known_mpi2_fams = [toolchain.MPICH, toolchain.MPICH2, toolchain.MVAPICH2, toolchan.OPENMPI, toolchain.IMPI]
if self.toolchain.mpi_family() in known_mpi2_fams:
mpi2 = True|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
... as derived from TC_CONSTANT_INTELMPI
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
fix long lines
|
Refer to this link for build results (access rights to CI server needed): |
|
Tested via easybuilders/easybuild-easyconfigs#1471, looking good, so going in. Thanks @ocaisa! |
No description provided.