Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
don't use self.__class__, since this will cause havoc for easyblocks deriving from EB_Xmipp
There was a problem hiding this comment.
right, it breaks inheratance, I forgot why I didn't recommend people to use this :p
|
@JensTimmerman: fully reviewed, looks pretty clean (after fixing the remarks) major remark is to not blindly assume deps you require the install root for are loaded, make sure they are by checking that |
There was a problem hiding this comment.
try:
os.chdir(self.cfg['start_dir'])
except OSError as err:
self.log.error("Failed to change back to %s: %s" % (self.cfg['start_dir'], err))|
further cleaned up, more remarks? |
Test resultBuild succeeded for 1 out of 1 Overview of tested easyconfigs (in order)
Time info
|
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
@boegel any more remarks? |
fix style issues
|
Refer to this link for build results (access rights to CI server needed): |
|
tested with easybuilders/easybuild-easyconfigs#1489, works like a charm, looking good, so going in, thanks @JensTimmerman! |
requires easybuilders/easybuild-framework#1229