Skip to content

replace 'log.error' with 'raise EasyBuildError'#588

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:log_error_to_raise_EasyBuildError
Mar 31, 2015
Merged

replace 'log.error' with 'raise EasyBuildError'#588
boegel merged 3 commits intoeasybuilders:developfrom
boegel:log_error_to_raise_EasyBuildError

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 30, 2015

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/893/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 30, 2015

I need a victim to to review this... @wpoely86, @rjeschmi?

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/894/
Test PASSed.

@wpoely86
Copy link
Copy Markdown
Member

Did a quick scan, looks fine

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/895/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 31, 2015

Going in together with easybuilders/easybuild-framework#1218, thanks for the review @rjeschmi and @wpoely86!

boegel added a commit that referenced this pull request Mar 31, 2015
replace 'log.error' with 'raise EasyBuildError'
@boegel boegel merged commit 33f4252 into easybuilders:develop Mar 31, 2015
@boegel boegel deleted the log_error_to_raise_EasyBuildError branch March 31, 2015 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants