tweak CP2K easyblock w.r.t. LAPACK/FFTW support#596
Merged
boegel merged 4 commits intoeasybuilders:developfrom Apr 24, 2015
Merged
tweak CP2K easyblock w.r.t. LAPACK/FFTW support#596boegel merged 4 commits intoeasybuilders:developfrom
boegel merged 4 commits intoeasybuilders:developfrom
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Member
There was a problem hiding this comment.
why have a default value here but not for FFT_INC_DIR etc?
Member
Author
There was a problem hiding this comment.
LIBS may not be set, FFT_INC_DIR should always be set
but I can add a proper default there too, thanks for the suggestion
|
Refer to this link for build results (access rights to CI server needed): |
Member
Author
|
Thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Apr 24, 2015
tweak CP2K easyblock w.r.t. LAPACK/FFTW support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
required to get CP2K to build on Cray