unset buildopts/installopts before installing Python extensions#597
unset buildopts/installopts before installing Python extensions#597boegel merged 1 commit intoeasybuilders:developfrom
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Looks good, but could be generalized in future for other stuff where we have extensions like R, Perl, etc. |
|
I wouldn't generalise it unless it's really needed, and even then I would make it optional by introducing an extra easyconfig parameter to enable/disable it. For it, only doing it here (where we have a use case for it) should suffice. |
|
@wpoely86: thoughts on this one? |
|
It looks ok, I just wonder whether it indicates there should be a stronger separation between the Lang EB and it's extensions. Probably something to think about, but this looks fine for now. |
There was a problem hiding this comment.
maybe we really should have a style guide. Some easyblocks have a empty line, some don't.
There was a problem hiding this comment.
if this is the main thing we're going to worry about, we should consider EB finished ;)
There was a problem hiding this comment.
but but but but, we need something to bitch about! How can we consider this to be a true OSS project if we can't bitch about style?
|
Looks fine IMHO. |
|
Thanks for the review everyone! |
unset buildopts/installopts before installing Python extensions
No description provided.