Update GCC easyblock for GCC 5#598
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Tested with easybuilders/easybuild-easyconfigs#1553, looking great, going in. Thanks @wpoely86! |
There was a problem hiding this comment.
hmm, hold on...
why isn't this:
if LooseVersion(self.version) < LooseVersion('5.0') ...We should be using LooseVersion everywhere where we check versions.
It may work now, but that's just by accident, I fear...
There was a problem hiding this comment.
Seems to work as expected without LooseVersion on both sides, but I don't trust it...
>>> from distutils.version import LooseVersion
>>> '4.9' < LooseVersion('5.0')
True
>>> '5.0' == LooseVersion('5.0')
True
>>> '5.1' < LooseVersion('5.0')
False
>>> '5.0' < LooseVersion('5.0')
False
>>>
@wpoely86: please fix consistently throughout the entire easyblock before we merge this is?
|
Refer to this link for build results (access rights to CI server needed): |
|
Going in, thanks @wpoely86! |
No description provided.