Skip to content

No need to check for compiler if the interfaces are not going to be b…#606

Merged
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:develop
May 7, 2015
Merged

No need to check for compiler if the interfaces are not going to be b…#606
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:develop

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

There is no need to check for compiler(s) if the interfaces are not being built.
The patch should be small enough to be easily understood.

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented May 7, 2015

Jenkins: ok to test

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/948/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 7, 2015

For future reference: this fixes an issue that pops up when (re)build the FFTW interfaces of MKL is disabled and a dummy toolchain is used. According to what @akesandgren has told me, (re)building the FFTW interfaces is no longer need with recent version of MKL, they're readily provided... To be figured out in detail (cfr. #607).

In any case, this change makes perfect sense, thanks for tackling this @akesandgren!

Welcome to the wonderful world of EasyBuild, and congrats on your first contribution (one of many, hopefully). This may be the quickest contribution yet after getting to know the project (< 24h)...

boegel added a commit that referenced this pull request May 7, 2015
No need to check for compiler if the interfaces are not going to be b…
@boegel boegel merged commit a78e0d1 into easybuilders:develop May 7, 2015
boegel added a commit that referenced this pull request May 13, 2015
No need to check for compiler if the interfaces are not going to be b…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants