make out-of-source build with CMake truly out-of-source#615
make out-of-source build with CMake truly out-of-source#615boegel merged 1 commit intoeasybuilders:developfrom
Conversation
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
yeah should be good |
|
why again didn't we make this the default in EB 2.0? |
|
I don't know. Maybe because it's hard to deprecate the current behaviour? |
|
Maybe, but it really should be the default to do it out of tree. |
|
Sure, but we need to test carefully before we flip the default. If the builds that now do not use an out-of-source build still work, I guess we can switch (we probably don't even have to wait until EB v3.0, then). Currently, 12 easyblocks derive from If we carefully compile a list of things to test after switching the default, it's doable. How about starting with a PR that changes the default (after this one is merged), and compiling a list of things to test there? |
|
good idea. lets have a look |
|
Retested on top of this, since they enable
(via
|
|
No existing builds were harmed (see above), as expected, so good to go in. Thanks for the review @wpoely86! |
make out-of-source build with CMake truly out-of-source
setting
separate_build_dir = Truein an easyconfig using theCMakeMakeeasyblock results in executing the build procedure in a subdirectory of the unpacked sourcesHowever, some packages (like CLHEP 2.2.x) require a true out-of-source build directory.
This fix should not break other easyconfigs that are already using
separate_build_dir = True(I'll verify that before merging).