Skip to content

add support in Bundle easyblock to run full sanity check#627

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:bundle_sanity_check
Jun 17, 2015
Merged

add support in Bundle easyblock to run full sanity check#627
boegel merged 3 commits intoeasybuilders:developfrom
boegel:bundle_sanity_check

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 15, 2015

This is required for bundles like R-bundle, to make sure the sanity check for the extensions is run.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 15, 2015

@wpoely86: please review?

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jun 15, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1018/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1018/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Jun 15, 2015

looks fine but can you not make it run the sanity check automatically when extensions are used?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 15, 2015

@wpoely86: Hmm, good idea. Also when sanity_check_paths or sanity_check_commands are given...

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jun 15, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1019/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1019/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 15, 2015

@wpoely86: please rereview?

wpoely86
wpoely86 reviewed Jun 15, 2015
View reviewed changes
Comment thread easybuild/easyblocks/x/xmipp.py Outdated
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Jun 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this related in some way?

Copy link
Copy Markdown
Member Author

@boegel boegel Jun 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh, crap, no, it's not :(

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 15, 2015

@wpoely86: please rereview?

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Jun 15, 2015

looks fine

@boegel boegel force-pushed the bundle_sanity_check branch from d37120a to 07f9c5b Compare June 15, 2015 11:40
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jun 15, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1020/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1020/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel mentioned this pull request Jun 17, 2015
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 17, 2015

Going in, thanks for the review @wpoely86!

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jun 17, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1027/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1027/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel added a commit that referenced this pull request Jun 17, 2015
@boegel
Merge pull request #627 from boegel/bundle_sanity_check
1eb7457 
add support in Bundle easyblock to run full sanity check
@boegel boegel merged commit 1eb7457 into easybuilders:develop Jun 17, 2015
@boegel boegel deleted the bundle_sanity_check branch June 17, 2015 09:57
@boegel boegel mentioned this pull request Jul 2, 2015
Merged
@boegel boegel mentioned this pull request Oct 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @hpcugentbot @wpoely86