fix Xmipp easyblock, use provided install.sh script (REVIEW)#630
fix Xmipp easyblock, use provided install.sh script (REVIEW)#630boegel merged 3 commits intoeasybuilders:developfrom
Conversation
|
This still has some hardcoding in place, so still WIP. |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
@pescobar: why are you not using $CFLAGS here as defined by EB?
There was a problem hiding this comment.
I tried this, the install,sh script screws up when $CXXFLAGS is passed because it contains spaces >_<
There was a problem hiding this comment.
tried that, the setup.py script being passed CXXFLAGS="$CXXFLAGS" trips over it (the quotes)
There was a problem hiding this comment.
have you tried escaping the spaces?
There was a problem hiding this comment.
You mean without using quotes at all? 😲
There was a problem hiding this comment.
like you do for java_home, but os.getenv('CXXFLAGS').replace(' ', '\ ') ?
There was a problem hiding this comment.
tried it:
--> ./setup.py -j 16 configure ... MPI_CC=mpicc CCFLAGS=-O2\ -march=native MPI_CXX=mpicxx ...
Traceback (most recent call last):
File "./setup.py", line 421, in <module>
exec(assign) # Take options from command line, override options file, be carefull with exec
File "<string>", line 1
CXXFLAGS = "-O2\"
There was a problem hiding this comment.
ok, using Python list syntax works (see http://xmipp.cnb.csic.es/twiki/bin/view/Xmipp/HowToInstall#Windows):
'CXXFLAGS=%s' % str(os.getenv('CXXFLAGS').split(' ')).replace(' ', ''),
nuts, but it does the job :)
…nstead; use MPICXX for MPI linker, set $PYTHONPATH via Xmipp module
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@JensTimmerman: please review? |
|
@boegel please fix your own remarks first? |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
good for me |
|
Thanks for the review @JensTimmerman! |
fix Xmipp easyblock, use provided install.sh script (REVIEW)
reworked Xmipp easyblock, partially based on the notes by @pescobar in #621