add easyblock for Molpro (REVIEW)#665
Conversation
|
Still testing this one, but early feedback can't hurt. :-) |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1113/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@wpoely86: please review |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1114/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1115/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1116/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
Isn't this already sufficiently done in the __init__?
There was a problem hiding this comment.
Yeah, also, I had to move this to the configure_step, for compatibility with --module-only.
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
why not do this at the beginning?
There was a problem hiding this comment.
ah, yes, this check can be removed, since we made sure it has been put in place at the start of configure_step
|
looks fine |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Tested with easyconfig in easybuilders/easybuild-easyconfigs#1880, works as intended, so going in. Thanks for the review @wpoely86! |
add easyblock for Molpro (REVIEW)
No description provided.