Skip to content

Update string matching#666

Merged
boegel merged 3 commits intoeasybuilders:developfrom
ocaisa:patch-6
Aug 14, 2015
Merged

Update string matching#666
boegel merged 3 commits intoeasybuilders:developfrom
ocaisa:patch-6

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Aug 14, 2015

In my tests of the latest versions of suitesparse this failed because you end up with something similiar to

-  CFLAGS = 
-# CFLAGS = -g
+CFLAGS = 
+ -static -fPIC -unroll -O3 -xHost -ftz -fp-speculation=safe -fp-model source # patched by EasyBuild# CFLAGS = -g

due to the \n not being matched

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 14, 2015

Automatic reply from Jenkins: Can I test this?

This was referenced Aug 14, 2015
Closed
Closed
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 14, 2015

Jenkins: ok to test

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 14, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1107/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1107/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel mentioned this pull request Aug 14, 2015
Merged
boegel
boegel reviewed Aug 14, 2015
View reviewed changes
Comment thread easybuild/easyblocks/s/suitesparse.py Outdated
Copy link
Copy Markdown
Member

@boegel boegel Aug 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the newline needs to be restored, see ocaisa#6

@boegel boegel added this to the v2.2.1 milestone Aug 14, 2015
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 14, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1109/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1109/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 14, 2015

Tested on existing SuiteSparse easyconfigs and approved. Thanks @ocaisa!

boegel added a commit that referenced this pull request Aug 14, 2015
@boegel
Merge pull request #666 from ocaisa/patch-6
f9cb66c 
Update string matching
@boegel boegel merged commit f9cb66c into easybuilders:develop Aug 14, 2015
@boegel boegel mentioned this pull request Aug 23, 2015
Merged
@ocaisa ocaisa deleted the patch-6 branch December 15, 2015 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ocaisa @hpcugentbot @boegel