Skip to content

add custom sanity check in scipy easyblock#669

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:scipy_sanity_check
Aug 23, 2015
Merged

add custom sanity check in scipy easyblock#669
boegel merged 3 commits intoeasybuilders:developfrom
boegel:scipy_sanity_check

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 23, 2015

required because of enabling fallback to default bin/lib sanity check paths due to easybuilders/easybuild-framework#1366

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1139/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1139/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel added this to the v2.2.1 milestone Aug 23, 2015
@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1140/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1140/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@pescobar
Copy link
Copy Markdown
Member

boegel it would be nice to add this in the sanity checking

python -c 'import scipy; scipy.test("full");

the same works for numpy...

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1141/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1141/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 23, 2015

@pescobar: the tests are already being run for scipy, this is triggered by this line in the scipy easyblock:

self.testcmd = "cd .. && python -c 'import numpy; import scipy; scipy.test(verbose=2)'" 

It seems like the tests are not being run yet for numpy, however...

So, this definitely needs to be fixed in a separate PR, since this PR fixes the broken sanity check for scipy...

boegel added a commit that referenced this pull request Aug 23, 2015
add custom sanity check in scipy easyblock
@boegel boegel merged commit b0d07cd into easybuilders:develop Aug 23, 2015
@boegel boegel deleted the scipy_sanity_check branch August 23, 2015 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants