Skip to content

add MCRROOT environmental variable#687

Merged
boegel merged 2 commits intoeasybuilders:developfrom
hajgato:mcrroot
Sep 15, 2015
Merged

add MCRROOT environmental variable#687
boegel merged 2 commits intoeasybuilders:developfrom
hajgato:mcrroot

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Sep 15, 2015

No description provided.

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1189/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

Comment thread easybuild/easyblocks/m/mcr.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hajgato: should use os.path.join(self.installdir, self.subdir) instead of self.subdir, since the latter is a relative path?

prepend_paths prefixes with the install prefix, set_environment does not since it may be something totally different than a filepath

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Sep 15, 2015

@boegel done!

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1190/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel added this to the v2.4.0 milestone Sep 15, 2015
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 15, 2015

Tested with existing MCR easyconfigs, works like a charm, thanks @hajgato!

boegel added a commit that referenced this pull request Sep 15, 2015
add MCRROOT environmental variable
@boegel boegel merged commit cb5eb78 into easybuilders:develop Sep 15, 2015
@hajgato hajgato deleted the mcrroot branch October 9, 2015 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants