EasyBlock for Apache Serf, handled by SCons#689
Conversation
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1193/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
looks good to me but I would promoted it to a generic SCONS easyblock? @hajgato up for that? |
|
This looks very generic indeed, let make this a generic |
There was a problem hiding this comment.
new easyblock, so use 2015-2015?
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1221/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
let do this like in the configuremake block, add an arg verbose=False and add log_output=verbose to the run_cmd.
|
@boegel: done |
|
lgtm, ready to merge |
|
Jenkins: test this please? |
1 similar comment
|
Jenkins: test this please? |
|
Jenkins: test this please |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1222/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Good to go in, thanks @hajgato! |
EasyBlock for Apache Serf, handled by SCons
There was a problem hiding this comment.
@hajgato: can you issue a follow-up PR to only run the tests in case self.cfg['runtest'] is True?
if self.cfg['runtest']:
(out, _) = run_cmd("scons check", log_all=True)
No description provided.