Fix getting pylibdir in easyblock for python_meep#694
Fix getting pylibdir in easyblock for python_meep#694boegel merged 2 commits intoeasybuilders:developfrom
Conversation
|
Automatic reply from Jenkins: Can I test this? |
There was a problem hiding this comment.
actually, a better fix would be to simply add the missing super call:
super(EB_python_minus_meep, self).configure_step()That will take care of this too, and more (debug logging w.r.t. Python version being used, for example)
|
Jenkins: ok to test |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1200/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1201/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@jas02: w.r.t. numpy: maybe we should include a check command like adding a comment in the python_meep easyconfigs wouldn't hurt either? |
|
Going in for EB v2.4.0, thanks @jas02! |
Fix getting pylibdir in easyblock for python_meep
python-meep package easyblock is broken. Currently, there is inherited method configure_step() that don't handle self.pylibdir variable. So during installation we have self.pylibdir 'UNKNOWN' and numpyinc like:
instead of correct one
Also, there is problem, that this easyblock count on numpy package in Python instance, not as separate module. This dependency is not mentioned in easyconfig.