Skip to content

enhance Bowtie easyblock: install additional binaries, make it version-aware#707

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:bowtie
Oct 7, 2015
Merged

enhance Bowtie easyblock: install additional binaries, make it version-aware#707
boegel merged 2 commits intoeasybuilders:developfrom
boegel:bowtie

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 7, 2015

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1254/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@ehiggs
Copy link
Copy Markdown
Contributor

ehiggs commented Oct 7, 2015

👍 Fixes a bug in v1.1.0 where more executables not listed were added to Bowtie. For 1.1.2 they moved to a more traditional approach that could be handled by MakeCp but I can see it making sense that we have an easy block for bowtie so we should use it so the differences in versions are written down.

@boegel boegel added this to the v2.4.0 milestone Oct 7, 2015
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 7, 2015

retested with all existing Bowtie easyconfigs + easybuilders/easybuild-easyconfigs#2035, so good to go

thanks for the review @ehiggs!

boegel added a commit that referenced this pull request Oct 7, 2015
enhance Bowtie easyblock: install additional binaries, make it version-aware
@boegel boegel merged commit bec1020 into easybuilders:develop Oct 7, 2015
@boegel boegel deleted the bowtie branch October 7, 2015 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants