Eigen: also copy signature file and don't copy CMake files#709
Merged
boegel merged 1 commit intoeasybuilders:developfrom Oct 8, 2015
torbjoernk:feature/eigen
Merged
Eigen: also copy signature file and don't copy CMake files#709boegel merged 1 commit intoeasybuilders:developfrom torbjoernk:feature/eigen
boegel merged 1 commit intoeasybuilders:developfrom
torbjoernk:feature/eigen
Conversation
The signature file is used by CMake's FindEigen module to determine the include path of Eigen3. The CMakeLists.txt files are only used by Eigen3's CMake based installation. Signed-off-by: Torbjörn Klatt <[email protected]>
|
Automatic reply from Jenkins: Can I test this? |
Member
|
Jenkins: ok to test |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1259/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Member
|
Looks great, tested with all existing Eigen easyconfigs, works like a charm, so going in. Thanks @torbjoernk! |
boegel
added a commit
that referenced
this pull request
Oct 8, 2015
Eigen: also copy signature file and don't copy CMake files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signature file is used by CMake's FindEigen module to determine the
include path of Eigen3.
The CMakeLists.txt files are only used by Eigen3's CMake based installation.