Remove custom post-install step in PDT easyblock#723
Merged
boegel merged 1 commit intoeasybuilders:developfrom Nov 2, 2015
Merged
Remove custom post-install step in PDT easyblock#723boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
|
Automatic reply from Jenkins: Can I test this? |
Member
|
Jenkins: ok to test |
Member
|
@geimer: please confirm that the PDT install still works with this easyblock on top of easybuilders/easybuild-framework#1439 |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1335/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Contributor
Author
|
Confirmed. See https://gist.github.com/geimer/62913a4b949b716333c5 for a typescript of building PDT with the |
Member
|
Going in, thanks @geimer! |
boegel
added a commit
that referenced
this pull request
Nov 2, 2015
Remove custom post-install step in PDT easyblock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDT creates symlinks to compiler-provided header files in its installation directory. When using an EB-installed compiler, there is no problem. However, when using the system compiler (e.g., by creating a corresponding EB module via
eb GCC-system.eb), the symlinks point to somewhere in/usrand fixing the permissions will fail.This custom post-install step was originally intended to suppress the fixing of permissions (which was part of the
post_install_stepat the time of writing the easyblock). Rather than suppressing thepermissions_stepinstead, we better rely on easybuilders/easybuild-framework#1439 once it is merged.