Skip to content

update Doxygen easyblock for 1.10.x (CMake) (REVIEW)#734

Merged
boegel merged 6 commits intoeasybuilders:developfrom
hajgato:doxygen_bump
Dec 10, 2015
Merged

update Doxygen easyblock for 1.10.x (CMake) (REVIEW)#734
boegel merged 6 commits intoeasybuilders:developfrom
hajgato:doxygen_bump

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Nov 4, 2015

No description provided.

Balazs Hajgato added 2 commits November 4, 2015 11:54
@boegel boegel added this to the v2.5.0 milestone Nov 4, 2015
Comment thread easybuild/easyblocks/d/doxygen.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self is not defined here

do the version check in configure_step, always import ConfigureMake

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boegel: Ok, but how I will switch to CMakeMake?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean where and how? Apparently 3rd works with the old (but then the EasyBlock is identical to the old), but not for the new.

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1341/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1342/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 4, 2015

@boegel seems to work.

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1343/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hajgato hajgato changed the title Doxygen bump (WIP) Doxygen bump (REVIEW) Nov 12, 2015
Comment thread easybuild/easyblocks/d/doxygen.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hajgato: the docstring should stay above the if

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it should be updated since we now have two cases...

what was so special about the --prefix below btw? I must be blind...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel was without =
the normal is --prefix=foo/bar and here is --prefix foo/bar

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1446/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

Comment thread easybuild/easyblocks/d/doxygen.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the wothout typo?

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1447/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel changed the title Doxygen bump (REVIEW) update Doxygen easyblock for 1.10.x (CMake) (REVIEW) Dec 10, 2015
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 10, 2015

Going in, thanks @hajgato!

boegel added a commit that referenced this pull request Dec 10, 2015
update Doxygen easyblock for 1.10.x (CMake) (REVIEW)
@boegel boegel merged commit 8c6fef1 into easybuilders:develop Dec 10, 2015
@hajgato hajgato deleted the doxygen_bump branch June 8, 2017 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants