Skip to content

Fix module path extension of system compiler in HMNS setup#742

Merged
boegel merged 3 commits intoeasybuilders:developfrom
geimer:systemcompiler
Nov 26, 2015
Merged

Fix module path extension of system compiler in HMNS setup#742
boegel merged 3 commits intoeasybuilders:developfrom
geimer:systemcompiler

Conversation

@geimer
Copy link
Copy Markdown
Contributor

@geimer geimer commented Nov 13, 2015

Running eb GCC-system.eb in an HMNS setup will create a module file GCC/system, which extends $MODULEPATH with <prefix>/modules/Compiler/GCC/<gcc_version>. However, this may conflict with an EasyBuild-created GCC installation of the same version. With this PR, the modulepath extension will be <prefix>/modules/Compiler/GCC/system.

Note: This PR also removes the custom post_install_step which originally was intended to skip changing permissions in system directories. However, this was moved to a separate step. In addition, EB only tries to modify permissions in <prefix>, i.e., suppressing this step is actually not needed at all.

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 14, 2015

Jenkins: ok to test

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 14, 2015

@geimer: looks fine, but maybe the comments should make it very clear what is meant by 'real version' and 'original version', for example by including examples mentioning 'system' or '4.9.2'?

@boegel boegel added this to the v2.5.0 milestone Nov 14, 2015
@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1360/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1361/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 26, 2015

retested installing GCC-system.eb in a couple of places on top of this, works fine, thanks @geimer!

boegel added a commit that referenced this pull request Nov 26, 2015
Fix module path extension of system compiler in HMNS setup
@boegel boegel merged commit 68c9828 into easybuilders:develop Nov 26, 2015
@geimer geimer deleted the systemcompiler branch November 27, 2015 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants