Skip to content

call set_netcdf_env_vars in prepare_step rather than configure_step in WRF easyblock#746

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:WRF_netcdf
Nov 24, 2015
Merged

call set_netcdf_env_vars in prepare_step rather than configure_step in WRF easyblock#746
boegel merged 1 commit intoeasybuilders:developfrom
boegel:WRF_netcdf

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 24, 2015

This change makes the WRF module generated using --module-only --force actually useable.

Without this, the WRF module would contains setenv NETCDF None, since the $NETCDF* environment variables do not get defined when using --module-only because configure_step is skipped.

@boegel boegel added this to the v2.5.0 milestone Nov 24, 2015
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 24, 2015

@wpoely86: please review?

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Nov 24, 2015

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1373/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Nov 24, 2015

looks good

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 24, 2015

Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Nov 24, 2015
@boegel
Merge pull request #746 from boegel/WRF_netcdf
7000f96 
call set_netcdf_env_vars in prepare_step rather than configure_step in WRF easyblock
@boegel boegel merged commit 7000f96 into easybuilders:develop Nov 24, 2015
@boegel boegel deleted the WRF_netcdf branch November 24, 2015 09:47
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 26, 2015

Hmm, unit tests are broken after this got merged:

ERROR [0.586s]: test_easyblock__Users_kehoste_work_easybuild-easyblocks_easybuild_easyblocks_w_wrf (test.easyblocks.module_only.ModuleOnlyTest)
Test for using --module-only with easyblock /Users/kehoste/work/easybuild-easyblocks/easybuild/easyblocks/w/wrf.py
----------------------------------------------------------------------
Traceback (most recent call last):
  File "<string>", line 1, in innertest
  File "test/easyblocks/module_only.py", line 139, in template_module_only_test
    app.run_all_steps(run_test_cases=False)
  File "/Users/kehoste/work/easybuild-framework/easybuild/framework/easyblock.py", line 2132, in run_all_steps
    self.run_step(step_name, step_methods)
  File "/Users/kehoste/work/easybuild-framework/easybuild/framework/easyblock.py", line 2011, in run_step
    step_method(self)()
  File "/Users/kehoste/work/easybuild-easyblocks/easybuild/easyblocks/w/wrf.py", line 76, in prepare_step
    set_netcdf_env_vars(self.log)
  File "/Users/kehoste/work/easybuild-easyblocks/easybuild/easyblocks/n/netcdf.py", line 117, in set_netcdf_env_vars
    raise EasyBuildError("netCDF module not loaded?")
EasyBuildError: 'netCDF module not loaded?'

The fail makes sense (and I can reproduce it locally), but I'm not sure why the PR tester didn't pick up on this...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 26, 2015

Jenkins: test this please

@boegel boegel mentioned this pull request Nov 26, 2015
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 26, 2015

Problem with test not failing when it should be was caused by the develop version of easyblocks being picked up via the easy_install.pth in $PYTHONPATH, which was intended to only be needed to pick up the EasyBuild framework develop install...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @hpcugentbot @wpoely86