use generic way of checking BLAS linkage for recent numpy versions#762

Merged

boegel merged 8 commits intoeasybuilders:developfrom

boegel:numpy_sanity_check_blas

Dec 8, 2015

Member

boegel commented Dec 7, 2015

implement generic way of checking BLAS linkage in numpy

check for blas_dot symbol (cfr. #757) doesn't always work, apparently (seems like it's not there when optimising more aggressively (-O3 vs -O2), or whne -fPIC is used)

cfr. numpy/numpy#6675 (comment)

boegel added 4 commits

December 7, 2015 19:07


          add generic way of checking BLAS linkage for recent numpy versions

88e7645


          fix typo

f3635b9


          trash check for 'blas_dot' symbol, not reliable

54542f2


          escape quotes in BLAS test

e076db6

boegel added this to the v2.5.0 milestone

Member Author

boegel commented Dec 7, 2015

@wpoely86: please review?


          correctly escape quotes in BLAS test

9e53935

boegel changed the title ~~use generic way of checking BLAS linkage for recent numpy versions~~ use generic way of checking BLAS linkage for recent numpy versions (WIP)

Member

wpoely86 commented Dec 7, 2015

looks good

hpcugentbot commented Dec 7, 2015

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1434/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot commented Dec 7, 2015

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1435/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.


          fix another typo

6577d25

hpcugentbot commented Dec 8, 2015

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1440/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.


          single-line sanity check command in numpy easyblock

3223e92

hpcugentbot commented Dec 8, 2015

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1441/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.


          fix quoting issues

803410b

hpcugentbot commented Dec 8, 2015

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1443/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel changed the title ~~use generic way of checking BLAS linkage for recent numpy versions (WIP)~~ use generic way of checking BLAS linkage for recent numpy versions

Member Author

boegel commented Dec 8, 2015

Tested by rebuilding with numpy 1.9 and 1.10 + Python easyconfigs, good to go, thanks for the review @wpoely86!

boegel added a commit that referenced this pull request


          Merge pull request #762 from boegel/numpy_sanity_check_blas

e3cfc0c

use generic way of checking BLAS linkage for recent numpy versions

boegel merged commit e3cfc0c into easybuilders:develop

boegel deleted the numpy_sanity_check_blas branch

December 8, 2015 16:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet