Skip to content

add support for using netCDF-Fortran as dependency in ALADIN easyblock (REVIEW)#764

Merged
boegel merged 4 commits intoeasybuilders:developfrom
boegel:ALADIN_gmkfilemaker
Dec 11, 2015
Merged

add support for using netCDF-Fortran as dependency in ALADIN easyblock (REVIEW)#764
boegel merged 4 commits intoeasybuilders:developfrom
boegel:ALADIN_gmkfilemaker

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 10, 2015

No description provided.

@boegel boegel added this to the v2.5.0 milestone Dec 10, 2015
@boegel boegel changed the title add support for using netCDF-Fortran as dependency in ALADIN easyblock add support for using netCDF-Fortran as dependency in ALADIN easyblock (WIP) Dec 10, 2015
@boegel boegel mentioned this pull request Dec 10, 2015
Merged
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Dec 10, 2015

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1454/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel changed the title add support for using netCDF-Fortran as dependency in ALADIN easyblock (WIP) add support for using netCDF-Fortran as dependency in ALADIN easyblock (REVIEW) Dec 11, 2015
wpoely86
wpoely86 reviewed Dec 11, 2015
View reviewed changes
Comment thread easybuild/easyblocks/a/aladin.py
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Dec 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_software_libdir doesn't give a full path?

Copy link
Copy Markdown
Member Author

@boegel boegel Dec 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, it doesn't

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 11, 2015

tested with easybuilders/easybuild-easyconfigs#2207, works as intended

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Dec 11, 2015

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1472/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 11, 2015

going in, thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Dec 11, 2015
@boegel
Merge pull request #764 from boegel/ALADIN_gmkfilemaker
9c4f9f4 
add support for using netCDF-Fortran as dependency in ALADIN easyblock (REVIEW)
@boegel boegel merged commit 9c4f9f4 into easybuilders:develop Dec 11, 2015
@boegel boegel deleted the ALADIN_gmkfilemaker branch December 11, 2015 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @hpcugentbot @wpoely86