Openfoam extend 3.2 update#770
Conversation
There was a problem hiding this comment.
hold on, did this actually disappear, or are you ignored something that went wrong during the build?
references?
There was a problem hiding this comment.
I cannot find a reference to it anymore in any Makefile. Test build works.
The src dir for it is also gone.
There was a problem hiding this comment.
Haven't run a complete test suite but as far as I can tell, it works
There was a problem hiding this comment.
I can't find anything on Pstream disappearing, and since this check is relatively recent (and not having the libPstream libraries went undetected for a while), cfr. https://github.com/hpcugent/easybuild-easyblocks/pull/436/files#diff-0edc74d66adc49c07871a687be0ef167R212, I'd like to get confirmation of this somehow...
I don't see any mention of Pstream in the OpenFOAM-Extend 3.2 release notes (http://sourceforge.net/p/openfoam-extend/foam-extend-3.1/ci/v3.2/tree/ReleaseNotes.txt), so it's fishy to me that this just disappeared...
Maybe @besserox has an idea?
There was a problem hiding this comment.
The Pstream library has apparently been removed in this commit:
http://sourceforge.net/p/foam-extend/foam-extend-3.2/ci/4c23c3f9e812674bf54b6a26e58f32511bb6af69/
It looks like it is now integrated in the main foam library.
What is important to check is that OpenFoam executables and libraries (eg libfoam.so) are actually linked to the MPI library of the toolchain, and not the one from the ThirdParty directory that they provide.
Running ldd lib/linux64GccDPOpt/libfoam.so should help to check this.
There was a problem hiding this comment.
This sounds like an additional sanity check command to me. @wpoely86?
There was a problem hiding this comment.
Will see if I can manage something but as I disable all third party stuff, this is extremely unlikely to happen.
There was a problem hiding this comment.
Doesn't hurt to have an extra sanity check for this imho, we've missed it before, we may introduce a bug that breaks it again...
|
It will clash, hence my request to merge it first. I will merge develop in here then |
|
@wpoely86: there are a couple of minor style remarks there, but it works, so should go in soon |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1474/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1475/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@wpoely86: please rebase on #744? I'd like to use this to test easybuilders/easybuild-easyconfigs#2048, easybuilders/easybuild-easyconfigs#2023, easybuilders/easybuild-easyconfigs#2216, easybuilders/easybuild-easyconfigs#2142 |
* develop: (37 commits) remove unused import don't set $GXX_ROOT, it breaks icpc finding C++ header files (undoes easybuilders#747 and easybuilders#771) Sytle corrected remove workaround for $CPATH including icc's 'include' subdir update $CPATH to include path to GCC C++ headers (complex.h) call configure/build scripts with 'python' to dance around /usr/bin/python hardcoding fix typo fix remarks add support for specifying altroot/altversion in Bundle easyblock enable -verbose update MRtrix easyblock for v0.3.x add easyblock for MRtrix move defining $GXX_ROOT to icc easyblock, only needed for icc/ifort improved implementation of determining value for $GXX_ROOT parse output of 'g++ --print-search-dirs' in Python Fix minor style issues, add copyright remove unused import if -> elif Add silent_cfg_extras variable Add i686 platform checking for IPP ...
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1506/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel It's ready for testing |
There was a problem hiding this comment.
I knew I had a reason for using dicts. This currently doesn't work due to this line. I don't see what's so weird about not using every key in every string formatting. It's what dicts are for?
There was a problem hiding this comment.
just hoist this out of the for loop below, and replace with:
env.setvar('%s_SYSTEM' % dep_name, '1')|
BTW, thanks for working on this one. I will need it very soon. |
|
@besserox: it's going to be tight, but still being considered |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1514/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
not so sure about this one... this is bound to break existing builds?
There was a problem hiding this comment.
no, only used in openfoam-extend 3.2 so far
style fixes in OpenFOAM easyblock
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1515/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1516/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Tested thoroughly with existing OpenFOAM(-Extend) easyconfigs + new OpenFOAM(-Extend) easyconfigs in easybuilders/easybuild-easyconfigs#2023, easybuilders/easybuild-easyconfigs#2048, easybuilders/easybuild-easyconfigs#2142 and easybuilders/easybuild-easyconfigs#2216. So, good to go, thanks @wpoely86! |
Add support for openfoam-extend 3.2