Skip to content

Extend OpenFoam-Extend sanity check for decomp libaries#784

Merged
boegel merged 15 commits intoeasybuilders:developfrom
wpoely86:openfoam-sanity
Sep 21, 2016
Merged

Extend OpenFoam-Extend sanity check for decomp libaries#784
boegel merged 15 commits intoeasybuilders:developfrom
wpoely86:openfoam-sanity

Conversation

@wpoely86
Copy link
Copy Markdown
Member

No description provided.

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1531/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel added this to the v2.6.0 milestone Dec 17, 2015
Comment thread easybuild/easyblocks/o/openfoam.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, why are we not checking this for both OpenFOAM and OpenFOAM-Extend?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because OpenFOAM has issues of its own: easybuilders/easybuild-easyconfigs#2236

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1533/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1534/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Copy Markdown
Member Author

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 23, 2016

@wpoely86: merge is broken

@boegel boegel modified the milestones: v2.7.0, v2.6.0 Jan 23, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 9, 2016

@wpoely86: ping (needs sync with develop)

@boegel boegel modified the milestones: v2.8.0, v2.7.0 Mar 9, 2016
* develop: (162 commits)
  Check only for key jar files to remove complicated checking logic for different versions
  Move log message
  Overwrite MakeCp options for mutil
  Rework rename & cp in makecp
  Rework mutil block
  Bugfix for makecp
  Moved some jar file sanity checks.
  ensure list of Python lib dirs always has a 'lib/...' entry
  Extend version of makecp: add support for renaming
  Easyblock for mutil
  fix bug in copying back libraries for GATE 6.1 and earlier
  use a loop
  also define $LD in buildopts for GATE
  added @author lucamar (I don't want to be sued)
  added cuda support directly to cp2k.py easyblock
  added cuda support directly to cp2k.py easyblock
  cp2k cray support
  more style fixes in MPICH easyblock
  fix remarks
  admit that @besserox was right
  ...
@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1792/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Copy Markdown
Member Author

wpoely86 commented Mar 9, 2016

@boegel rereview please

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 9, 2016

@besserox: thoughts?

@besserox
Copy link
Copy Markdown
Contributor

@wpoely86 It looks good to me.

One small remarks:
Can you keep these comments around for both OpenFOAM and OpenFOAM-Extend?

# check for the Pstream and *Decomp libraries
# Pstream should have both a dummy and a mpi one

Thanks!

@wpoely86
Copy link
Copy Markdown
Member Author

@besserox okay done

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1803/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel modified the milestones: v2.8.0, v2.9.0 May 10, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 20, 2016

(close/open to trigger Travis)

@boegel boegel closed this Sep 20, 2016
@boegel boegel reopened this Sep 20, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 20, 2016

@wpoely86 please review/merge wpoely86#26 ; without this, I couldn't verify this PR via --module-only

make sure required env vars/modules/toolchain is used for OpenFOAM(-Extend) & IMOD --module-only test
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 21, 2016

good to go, thanks @wpoely86!

@boegel boegel merged commit 3922479 into easybuilders:develop Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants