Skip to content

use find_flexlm_license function in IntelBase generic easyblock#839

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:intel_find_flexlm_license
Mar 9, 2016
Merged

use find_flexlm_license function in IntelBase generic easyblock#839
boegel merged 3 commits intoeasybuilders:developfrom
boegel:intel_find_flexlm_license

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 25, 2016

requires easybuilders/easybuild-framework#1633

see discussion in #837 (cc @damianam, @valtandor)

also fixes #555 (cc @pescobar)

@boegel boegel added this to the v2.7.0 milestone Feb 25, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 25, 2016

@wpoely86: please review?

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1710/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

from easybuild.framework.easyconfig import CUSTOM
from easybuild.tools.build_log import EasyBuildError
from easybuild.tools.filetools import read_file
from easybuild.tools.filetools import find_flexlm_license, read_file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't really need read_file

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needed, in parse_components_list

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Mar 4, 2016

👍

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 4, 2016

Jenkins: test this please

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1754/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

self.log.info("Using Intel license specifications from $%s: %s", self.license_env_var, lic_specs)

self.license_file = os.pathsep.join(lic_specs)
self.cfg['license_file'] = self.license_file
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed?

cc @damianam

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1797/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 9, 2016

retested after last change with all Intel tools, good to go

Thanks for the feedback @wpoely86 and @damianam!

boegel added a commit that referenced this pull request Mar 9, 2016
use find_flexlm_license function in IntelBase generic easyblock
@boegel boegel merged commit 70a6ddc into easybuilders:develop Mar 9, 2016
@boegel boegel deleted the intel_find_flexlm_license branch March 9, 2016 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants