Skip to content

fix check for non-empty lib dirs in PythonPackage easyblock#840

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:fix_libdir_check_PythonPackage
Feb 25, 2016
Merged

fix check for non-empty lib dirs in PythonPackage easyblock#840
boegel merged 1 commit intoeasybuilders:developfrom
boegel:fix_libdir_check_PythonPackage

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 25, 2016

os.listdir returns only the filenames, not the full paths...

cc @wpoely86

edit: for future reference: this caused $LD_LIBRARY_PATH to be not defined for libxml2...

@boegel boegel added this to the v2.7.0 milestone Feb 25, 2016
@wpoely86
Copy link
Copy Markdown
Member

lgtm

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1711/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 25, 2016

Going in, I'll see if we can come up with a test dir this...

boegel added a commit that referenced this pull request Feb 25, 2016
fix check for non-empty lib dirs in PythonPackage easyblock
@boegel boegel merged commit a09618d into easybuilders:develop Feb 25, 2016
@boegel boegel deleted the fix_libdir_check_PythonPackage branch February 25, 2016 13:16
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 25, 2016

@wpoely86: test implemented in #841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants