Cray support for boost by gppezzi · Pull Request #849 · easybuilders/easybuild-easyblocks

gppezzi · 2016-03-02T14:21:14Z

This easyblock is a tweaked version of boost.py for supporting Cray.

I don't know if it is preferable to include Cray support on the original one (but I don't want to break existing builds...)

hpcugentbot · 2016-03-02T14:22:07Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1735/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

ocaisa · 2016-03-02T14:41:52Z

Wouldn't you be better off inheriting from the existing boost easyblock and only changing what you need to...or building the necessary logic into the existing boost easyblock?

gppezzi · 2016-03-02T14:49:55Z

@ocaisa sure, but I'd like to hear what's the recommended way before tackling that...

pforai · 2016-03-02T15:00:41Z

Just FIY: This block is based on my PR that I submitted some time ago and this has the problem that it expects aprun to be available on the machine where you build things.

boegel · 2016-03-02T15:18:01Z

+1 for deriving from existing Boost easyblock, (way) too much copy-pasting now...

hpcugentbot · 2016-03-02T16:07:56Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1737/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-03-02T16:08:47Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1738/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

gppezzi · 2016-03-02T16:16:34Z

@ocaisa @boegel @pforai @lucamar I did some clean up, can you please review the new version?

pforai · 2016-03-02T16:17:56Z

+            self.log.info("PRGENV_MODULE_NAME_SUFFIX is %s " % (self.toolchain.PRGENV_MODULE_NAME_SUFFIX))
+#	    self.log.info("TC_CONSTANT_CRAYPE is %s " % (self.toolchain.TC_CONSTANT_CRAYPE))
+            #if self.toolchain.TC_CONSTANT_CRAYPE in [toolchain.CRAYPE+'_GNU', toolchain.CRAYPE+'_Intel'] :
+            if self.toolchain.PRGENV_MODULE_NAME_SUFFIX in ['gnu', 'intel'] :


This would need to be a bit more specific and should also contain a conditional branch for 'cce' and 'pgi' probably (even if that would be just to bail).

@pforai I've added cray to the list but since we check for a cray toolchain (and I'm not planning to fix boost on -cray or -intel right now), maybe I'll just drop this test for the moment?

unless someone volunteers to work on the intel/cray boost support...

boegel · 2016-03-02T19:13:02Z

Any chance to just enhance the existing boost.py?

Do we have a good way of checking whether we're running eb on a Cray system yet?

Or does self.toolchain.name.startswith('Cray') suffice (since it's really only if we're using the Cray* toolchains that we need to take special care; you can also build with foss on a Cray system but there's nothing really special about that imho).

gppezzi · 2016-03-02T19:35:27Z

@boegel well I dont feel confident enough to modify the original easyblock without breaking other builds (meaning that I don't have much time for testing now, I'm just bulk pushing things that were waiting for the new cray toolchains).

But if that boils down to adding an extra test to check if TC is Cray*, then I think I can do it ;) I'll start with self.toolchain.name.startswith('Cray')

boegel · 2016-03-03T07:45:25Z

@gppezzi we can help out with testing and making sure you're not breaking backwards compatibility;

It's good that you're pushing out the things you've worked on, and are willing to take the effort to contribute back, thanks for that!

hpcugentbot · 2016-03-07T16:42:26Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1767/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

gppezzi · 2016-03-07T17:02:07Z

@boegel @pforai I've integrated the changes into boost.py, it seems to build, can you please review?

thx

boegel · 2016-03-09T19:46:21Z

+            else:
+                f.write("using mpi : %s ;" % os.getenv("MPICXX"))

+            f.close()           


please replace this with:

write_file('user-config.jam', txt, append=True)

and construct txt above

hpcugentbot · 2016-03-09T21:28:05Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1799/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-03-09T21:38:19Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1800/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-03-09T21:41:47Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1801/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-03-09T21:42:37Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1802/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

gppezzi · 2016-03-09T21:43:19Z

@boegel fixed most of remarks, I'll check tomorrow how to correctly bail out in case of unsupported PrgEnv

gppezzi · 2016-06-15T21:19:06Z

@boegel @pforai @lucamar

I've updated the easyblock to avoid the hardcoded reference to aprun/srun, now the mpi launcher can be specified through an extra_var. This argument is optional and it is only used for the regression tests (which we are currently not doing).

@pforai The argument <find-shared-library>mpich is actually needed for building the mpi enabled libraries, so apparently we need to leave it.

Build reports will be provided here

lucamar · 2016-06-16T07:33:28Z

@gppezzi Thanks, it looks perfect

boegel · 2016-06-17T08:06:56Z

+            else:
+                txt = "using mpi : %s ;" % os.getenv("MPICXX")
+
+        write_file('user-config.jam', txt, append=True)


@gppezzi indentation seems off here? should be intended one level deeper, so it's in the if self.cfg['boost_mpi']:, otherwise txt is undefined

fix indent on write_file for user-config.jam + minor style issues in Boost easyblock

boegel · 2016-06-17T09:03:31Z

Tested with easybuilders/easybuild-easyconfigs#2615 and existing Boost easyconfigs, good to go, thanks @gppezzi & @pforai!

gppezzi · 2016-06-17T09:06:43Z

Thanks everyone for the feedback and help!

cray support for boost

eb0d84a

gppezzi mentioned this pull request Mar 2, 2016

Boost 1.60 CrayGNU-2016.03 easybuilders/easybuild-easyconfigs#2615

Merged

gppezzi added 2 commits March 2, 2016 16:56

I love copy&pasting but I'm cleaning up a bit here

f1a330e

minor

cbc398a

pforai reviewed Mar 2, 2016
View reviewed changes

boegel added this to the v2.7.0 milestone Mar 2, 2016

integrating cray specific changes to boost.py

7c4e474

boegel reviewed Mar 9, 2016
View reviewed changes

boegel modified the milestones: v2.8.0, v2.7.0 Mar 9, 2016

fixed remarks

cf33df8

now using write_file

8b5297b

gppezzi added 2 commits March 9, 2016 22:40

minor style fix

4ddd5f4

minor

4fd5bbf

boegel modified the milestones: v2.8.0, v2.9.0 May 10, 2016

gppezzi mentioned this pull request Jun 9, 2016

{bio}[CrayGNU/2016.03] GROMACS v5.1.2 easybuilders/easybuild-easyconfigs#3195

Merged

gppezzi added 2 commits June 15, 2016 21:02

minor changes

4a5d0f2

added mpi launcher option

1a03615

boegel reviewed Jun 17, 2016
View reviewed changes

boegel added 2 commits June 17, 2016 10:08

fix indent on write_file for user-config.jam

db2b874

fix minor style issues in Boost easyblock

840d839

boegel mentioned this pull request Jun 17, 2016

fix indent on write_file for user-config.jam + minor style issues in Boost easyblock gppezzi/easybuild-easyblocks#2

Merged

Merge pull request #2 from boegel/boost_cray

d8223d8

fix indent on write_file for user-config.jam + minor style issues in Boost easyblock

boegel merged commit 59261a2 into easybuilders:develop Jun 17, 2016

Conversation

gppezzi commented Mar 2, 2016

Uh oh!

hpcugentbot commented Mar 2, 2016

Uh oh!

ocaisa commented Mar 2, 2016

Uh oh!

gppezzi commented Mar 2, 2016

Uh oh!

pforai commented Mar 2, 2016

Uh oh!

boegel commented Mar 2, 2016

Uh oh!

hpcugentbot commented Mar 2, 2016

Uh oh!

hpcugentbot commented Mar 2, 2016

Uh oh!

gppezzi commented Mar 2, 2016

Uh oh!

pforai Mar 2, 2016

Choose a reason for hiding this comment

Uh oh!

gppezzi Mar 7, 2016

Choose a reason for hiding this comment

Uh oh!

boegel commented Mar 2, 2016

Uh oh!

gppezzi commented Mar 2, 2016

Uh oh!

boegel commented Mar 3, 2016

Uh oh!

hpcugentbot commented Mar 7, 2016

Uh oh!

gppezzi commented Mar 7, 2016

Uh oh!

boegel Mar 9, 2016

Choose a reason for hiding this comment

Uh oh!

hpcugentbot commented Mar 9, 2016

Uh oh!

hpcugentbot commented Mar 9, 2016

Uh oh!

hpcugentbot commented Mar 9, 2016

Uh oh!

hpcugentbot commented Mar 9, 2016

Uh oh!

gppezzi commented Mar 9, 2016

Uh oh!

gppezzi commented Jun 15, 2016

Uh oh!

lucamar commented Jun 16, 2016

Uh oh!

boegel Jun 17, 2016

Choose a reason for hiding this comment

Uh oh!

boegel commented Jun 17, 2016

Uh oh!

gppezzi commented Jun 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants