Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1736/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

Same remark as for Boost: this should be reworked to reuse the efforts in cp2k.py, rather than copy-paste; this is a maintenance nightmare as is...

I just did the diff, we're actually just adding CUDA support:

         # CUDA
         cuda = get_software_root('CUDA')
         if cuda:
             options['DFLAGS'] += ' -D__ACC -D__DBCSR_ACC'
             options['LIBS'] += ' -lcudart -lcublas -lcufft -lrt'
             options['NVCC'] = ' nvcc'

It looks like harmless to add this to the existing cp2k easyblock, what do you say ?

Looks reasonable, yeah.

Can you update this PR to actually make it modify the existing cp2k.py?

cp easybuild/easyblocks/c/cp2kcray.py easybuild/easyblocks/c/cp2k.py
git rm easybuild/easyblocks/c/cp2kcray.py
git commit -a -m "..."
...

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1741/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1742/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1743/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel cuda support is integrated into the existing easyblock, can you please review?

@lucamar any remarks?

lgtm, thanks @gppezzi and @lucamar!

Tested a couple of CP2K builds on top of this, (still) working fine, so good to go.