Remove deprecated configure options from MVAPICH2 easyblock#853
Remove deprecated configure options from MVAPICH2 easyblock#853boegel merged 14 commits intoeasybuilders:developfrom
Conversation
|
Automatic reply from Jenkins: Can I test this? |
| extra_vars = { | ||
| 'withchkpt': [False, "Enable checkpointing support (required BLCR)", CUSTOM], | ||
| 'withmpe': [False, "Build MPE routines", CUSTOM], | ||
| 'withhwloc': [False, "Enable support for using hwloc support for process binding", CUSTOM], |
There was a problem hiding this comment.
these shouldn't be removed
although we can update the easyconfigs we ship ourselves accordingly, we should forget that there are other easyconfigs out there we do not control...
|
Jenkins: ok to test |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1748/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Just some notes, for later:
|
…with MVAPICH2 >= 2.0
…to cleanup_mvapich2
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1761/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel This PR is not doing much now except documenting a bit more the issues.
Let me know if you have a better behavior to propose. |
| # and it cannot be disabled. | ||
| # The 'withhwloc' option should be maintained for backward compatibility purpose. | ||
| # EasyBuild and MVAPCH2 will just silently ignore this option if it is used. | ||
| add_configopts.append('--with-hwloc') |
There was a problem hiding this comment.
is this actually still a known configure option in MVAPICH >= 2.0?
if not, we should not use it anymore...
cfr. #157
There was a problem hiding this comment.
Two things:
--with-hwlocis not recognized by the configure (but it is still in the documentation). I can clarify this with the MVAPICH2 team.- The
configurefrom MPICH/MVAPCH2 is not checking for the unrecognized options. Because they use a top-level configure which is calling many other configure scripts with all the same options (some options being used by some configure scripts, and not by other ones). So trip over unknown configure options #157 will not apply here.
There was a problem hiding this comment.
OK, but does it make any sense to include it, since it has no effect?
So, we should just skip it and issue a warning for MVAPICH >= 2.0?
|
@besserox: the logic makes sense to me, but we could do a little bit better (cfr. remarks) |
…to cleanup_mvapich2
…to cleanup_mvapich2
This does not change the behavior of old easyconfig files because: - previously, if withhwloc was False, we did not set explicitly '--without-hwloc' - and if '--without-hwloc' was not set, the actual default behavior of the configure was to enable it
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1811/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel This should be better now. One change is that the default value for So now I'm able to find out detect if the easyconfig set |
spacing cleanup, easier to follow logic, fix long line
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1825/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@besserox: this needs besserox#6 to fix a merge conflict (because #854 was merged) |
sync with develop & resolve conflict
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1827/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
retested with all existing MVAPICH2 easyconfigs through easybuilders/easybuild-easyconfigs#2707, good to go, thanks @besserox! |
Remove deprecated configure options from MVAPICH2 easyblock
MVAPICH2 easyblock uses some deprecated configure options:
--enable-mpedisappeared starting version >= 1.9--enable-hwlocdisappeared starting version >= 2.0This PR removes these deprecated options from the easyblock.
PR easybuilders/easybuild-easyconfigs#2626 for easyconfigs set these options directly in the easyconfig files when there are used.
PR easybuilders/easybuild-easyconfigs#2626 have to be merged first.