hunt for usable 'python' command in PythonPackage easyblock when system Python is used#861
Conversation
…em Python is used
|
@wpoely86: please review |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1774/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| if req_min_ver is not None: | ||
| # check minor version | ||
| pycode = 'import sys; print "%s.%s" % sys.version_info[:2]' | ||
| out, _ = run_cmd("%s -c '%s'" % (python_cmd, pycode), simple=False) |
There was a problem hiding this comment.
maybe do 1 python call and use zero for req_min_ver if it's not specified?
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1775/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
👍 |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1776/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1777/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1778/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1780/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1781/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| kwargs.update({'exts_filter': EXTS_FILTER_PYTHON_PACKAGES}) | ||
| if 'exts_filter' not in kwargs: | ||
| orig_exts_filter = EXTS_FILTER_PYTHON_PACKAGES | ||
| exts_filter = (orig_exts_filter[0].replace('python', self.python_cmd), orig_exts_filter[1]) |
There was a problem hiding this comment.
for extensions being used with the system Python, we need to make sure we use the right Python command when doing import tests (which may be python2 rather than python)
this is important for installing the GC3Pie bundle, for example (https://github.com/hpcugent/easybuild-easyconfigs/blob/master/easybuild/easyconfigs/g/GC3Pie/GC3Pie-2.4.2.eb)
|
This is good to go, I've thoroughly tested this by rebuilding the following:
|
|
Thanks for the review @wpoely86! |
hunt for usable 'python' command in PythonPackage easyblock when system Python is used
This is required to fix the problem with bootstrapping EasyBuild in an environment where Python 3.x is the default
python, and wherepython2is also available.