Conversation
|
@wpoely86: please review? |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1812/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| # originally created by the HPC team of Ghent University (http://ugent.be/hpc/en), | ||
| # with support of Ghent University (http://ugent.be/hpc), | ||
| # the Flemish Supercomputer Centre (VSC) (https://vscentrum.be/nl/en), | ||
| # the Hercules foundation (http://www.herculesstichting.be/in_English) |
| if success_msg not in out: | ||
| raise EasyBuildError("Success message '%s' not found in setup.sh output: %s", success_msg, out) | ||
|
|
||
| def install_step(self): |
There was a problem hiding this comment.
why not inherited from MakeCp with custom build (instead of copy the cp thingie?)
There was a problem hiding this comment.
I did that at first, but MakeCp requires using files_to_copy (in the easyconfig)
and this install_step is not copying the MakeCp.install_step, since it's copying very specific things (see binfiles)
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1813/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Tested via easybuilders/easybuild-easyconfigs#2701, good to go, thanks for the review @wpoely86! |
this is a cleaned up/improved version of #394 by @ehiggs