Add PGI support to imkl easyblock by ocaisa · Pull Request #866 · easybuilders/easybuild-easyblocks

ocaisa · 2016-03-11T13:07:11Z

Depends on ~~easybuilders/easybuild-framework#1342~~

hpcugentbot · 2016-03-11T13:13:49Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1814/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

ocaisa · 2016-03-11T13:50:08Z

Not so trivial, no PGI support for fftw2x_cdft. I can fix it with a simple patch on their makefile (use a string replace for gnu -> pgi, gcc -> pgcc, -Wall -> '') or we could leave it out?

boegel · 2016-03-11T13:55:59Z

@ocaisa The toolchain support for the FFTW wrappers in Intel MKL (intelfftw.py) will check whether the FFTW wrapper are there, but it seems like it only checks the fftw3 stuff...

hpcugentbot · 2016-03-11T14:12:56Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1815/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-03-11T14:26:47Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1816/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-03-11T14:43:49Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1817/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-03-11T14:44:36Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1818/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-03-11T15:11:44Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1820/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-03-11T15:13:04Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1821/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-03-11T15:33:49Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1822/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-03-11T15:35:13Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1823/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

ocaisa · 2016-03-11T15:55:30Z

@boegel Success! This works now.

hpcugentbot · 2016-03-11T15:56:54Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1824/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2016-05-10T20:06:03Z

+                        run_cmd("sed -i s/gnu/pgi/g makefile", log_all=True, simple=True)
+                        run_cmd("sed -i s/gcc/pgcc/g makefile", log_all=True, simple=True)
+                        run_cmd("sed -i s/-Wall//g makefile", log_all=True, simple=True)
+                        run_cmd("sed -i s/-std=c99/-c99/g makefile", log_all=True, simple=True)


these should be done with apply_regex_substitutions?

@ocaisa: I can try and tackle that and send you a PR, or wrap your existing PR...

regex not my strong point, happy to take a PR

clean up patching of fftw*cdft/makefile for PGI

hpcugentbot · 2016-05-11T10:16:37Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1981/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

explain regex subs for -c99 and -Wall with comment

hpcugentbot · 2016-05-11T12:19:08Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1982/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2016-05-11T14:45:10Z

tested with imkl easyconfig using pompi toolchain from easybuilders/easybuild-easyconfigs#2900 (on top of easybuilders/easybuild-framework#1664 and easybuilders/easybuild-framework#1724), and with several exsting imkl easyconfigs, works great

So, good to go, thanks for figuring this out @ocaisa!

Add PGI support to imkl easyblock

7c7e9e9

ocaisa mentioned this pull request Mar 11, 2016

Add PGI support to MKL easybuilders/easybuild-framework#1664

Merged

boegel added this to the v2.8.0 milestone Mar 11, 2016

Add patch for fftw2x_cdft

80c995f

Only do patch once

6ba097a

Alan added 2 commits March 11, 2016 15:42

Only do patch once

7ee4ceb

Only do patch once

e8e4a07

Alan added 2 commits March 11, 2016 16:06

Need another sed

777195a

Need another sed

73baa45

Alan added 2 commits March 11, 2016 16:25

Add PGI to sanity check too

fb43694

Add PGI to sanity check too

0b4376d

wrong var name

9058c6e

This was referenced Apr 15, 2016

PGI: add pompi and pomkl toolchains (similar to iompi and iomkl). easybuilders/easybuild-framework#1724

Merged

PGI: add pomkl-2016.03 toolchain + imkl-11.3.2.181-pompi + HPL easybuilders/easybuild-easyconfigs#2900

Merged

boegel mentioned this pull request Apr 15, 2016

PGI support (roadmap) easybuilders/easybuild#211

Closed

10 tasks

boegel reviewed May 10, 2016
View reviewed changes

clean up patching of fftw*cdft/makefile for PGI

63aca1c

boegel mentioned this pull request May 11, 2016

clean up patching of fftw*cdft/makefile for PGI ocaisa/easybuild-easyblocks#8

Merged

boegel and others added 2 commits May 11, 2016 12:07

consider PGI before GCC when checking compilers

23f2521

Merge pull request #8 from boegel/pgi_mkl

fbc5e6b

clean up patching of fftw*cdft/makefile for PGI

explain regex subs for -c99 and -Wall with comment

810078e

boegel mentioned this pull request May 11, 2016

explain regex subs for -c99 and -Wall with comment ocaisa/easybuild-easyblocks#9

Merged

Merge pull request #9 from boegel/pgi_mkl

7f899bc

explain regex subs for -c99 and -Wall with comment

boegel merged commit c057903 into easybuilders:develop May 11, 2016

ocaisa deleted the pgi_mkl branch May 11, 2016 15:56

boegel mentioned this pull request May 12, 2016

{toolchain}[pomkl/2016.04] HPL 2.1 (REVIEW) easybuilders/easybuild-easyconfigs#3044

Merged

Conversation

ocaisa commented Mar 11, 2016 • edited by boegel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hpcugentbot commented Mar 11, 2016

Uh oh!

ocaisa commented Mar 11, 2016

Uh oh!

boegel commented Mar 11, 2016

Uh oh!

hpcugentbot commented Mar 11, 2016

Uh oh!

hpcugentbot commented Mar 11, 2016

Uh oh!

hpcugentbot commented Mar 11, 2016

Uh oh!

hpcugentbot commented Mar 11, 2016

Uh oh!

hpcugentbot commented Mar 11, 2016

Uh oh!

hpcugentbot commented Mar 11, 2016

Uh oh!

hpcugentbot commented Mar 11, 2016

Uh oh!

hpcugentbot commented Mar 11, 2016

Uh oh!

ocaisa commented Mar 11, 2016

Uh oh!

hpcugentbot commented Mar 11, 2016

Uh oh!

boegel May 10, 2016

Choose a reason for hiding this comment

Uh oh!

ocaisa May 10, 2016

Choose a reason for hiding this comment

Uh oh!

hpcugentbot commented May 11, 2016

Uh oh!

hpcugentbot commented May 11, 2016

Uh oh!

boegel commented May 11, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ocaisa commented Mar 11, 2016 •

edited by boegel

Loading