Skip to content

change suffix of original file to .easybuild when using fileinput in impi easyblock#870

Merged
boegel merged 1 commit intoeasybuilders:developfrom
ocaisa:patch-1
Mar 15, 2016
Merged

change suffix of original file to .easybuild when using fileinput in impi easyblock#870
boegel merged 1 commit intoeasybuilders:developfrom
ocaisa:patch-1

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Mar 15, 2016

The .eb extension is a bad choice because it actually means something

The .eb extension is a bad choice because it actually means something
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Mar 15, 2016

The original messed up scripts I have that automatically pull easyconfigs from existing installations

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 15, 2016

@ocaisa looks ok to include, but your script shouldn't be picked up .eb files from random locations?

@boegel boegel added this to the v2.7.0 milestone Mar 15, 2016
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Mar 15, 2016

I never said it was my script...

@hpcugentbot
Copy link
Copy Markdown

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1850/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel changed the title Update impi.py change suffix of original file to .easybuild when using fileinput in impi easyblock Mar 15, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 15, 2016

going in, thanks @ocaisa

boegel added a commit that referenced this pull request Mar 15, 2016
change suffix of original file to .easybuild when using fileinput in impi easyblock
@boegel boegel merged commit 5954972 into easybuilders:develop Mar 15, 2016
@ocaisa ocaisa deleted the patch-1 branch October 27, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants