PGI: delete libnuma symbolic links in installation directory#888
PGI: delete libnuma symbolic links in installation directory#888boegel merged 3 commits intoeasybuilders:developfrom
Conversation
If the PGI installer does NOT find an OS libnuma, makelocalrc creates symbolic links to libpgnuma.so. Since we use the EasyBuild libnuma, delete those symbolic links.
|
Automatic reply from Jenkins: Can I test this? |
| for filename in ["libnuma.so", "libnuma.so.1"]: | ||
| path = os.path.join(install_abs_subdir, "lib", filename) | ||
| if os.path.islink(path): | ||
| os.remove(path) |
There was a problem hiding this comment.
@bartoldeman: you should only do this if numactl is actually included as a dependency?
use if get_software_root('numactl') to check
|
Jenkins: ok to test |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1885/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1886/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1887/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
|
||
| # If an OS libnuma is NOT found, makelocalrc creates symbolic links to libpgnuma.so | ||
| # If we use the EB libnuma, delete those symbolic links to ensure they are not used | ||
| if get_software_root("numactl"): |
There was a problem hiding this comment.
you'll need to import this function too, i.e. add this on top (in alphabetical order compared to the ones already there):
from easybuild.tools.modules import get_software_rootThere was a problem hiding this comment.
Thanks and sorry for the mishap! Done, now tested correctly.
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1888/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Tested with easybuilders/easybuild-easyconfigs#2879, looks good, go going in, thanks @bartoldeman! |
If the PGI installer does NOT find an OS libnuma, makelocalrc creates
symbolic links to libpgnuma.so.
Since we use the EasyBuild libnuma, delete those symbolic links.